Messages in this thread | | | Date | Tue, 2 Aug 2022 15:17:05 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 2/3] perf lock: Add -m/--map-length option |
| |
Em Tue, Aug 02, 2022 at 11:05:09AM -0700, Namhyung Kim escreveu: > On Tue, Aug 2, 2022 at 10:43 AM Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > > Em Tue, Aug 02, 2022 at 12:35:10AM -0700, Namhyung Kim escreveu: > > > +-m:: > > > +--map-length:: > > > + Maximum number of BPF map entries (default: 10240). > > > > --map-nr-entries? > > > > I think we use this jargon "nr-entries" for arrays, lists, etc, better > > try to stick to it.
> Makes sense, will change.
Great.
> > Also what do you think about not using single letter options for things > > that are not that used? > > > > The map size has a default, one that seems generous, so changing it > > should be something uncommon, and then, if it becomes common that more > > entries are needed by default, we can change the default in the tool. > > Fair enough, I'll remove the single letter option.
Thanks!
- Arnaldo
| |