Messages in this thread | | | Date | Tue, 2 Aug 2022 09:43:59 +0300 | Subject | Re: [PATCH] drm/msm/gpu: Drop qos request if devm_devfreq_add_device() fails | From | Dmitry Baryshkov <> |
| |
On 08/07/2022 19:26, Bjorn Andersson wrote: > In the event that devm_devfreq_add_device() fails the device's qos freq > list is left referencing df->idle_freq and df->boost_freq. Attempting to > initialize devfreq again after a probe deferral will then cause invalid > memory accesses in dev_pm_qos_add_request(). > > Fix this by dropping the requests in the error path. > > Fixes: 7c0ffcd40b16 ("drm/msm/gpu: Respect PM QoS constraints") > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> --- > drivers/gpu/drm/msm/msm_gpu_devfreq.c | 2 ++ > 1 file changed, 2 insertions(+)
-- With best wishes Dmitry
| |