lkml.org 
[lkml]   [2022]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/3] dt-bindings: remoteproc: Add AVM WASP
On Sat, Jul 23, 2022 at 09:42:46AM +0200, Daniel Kestrel wrote:
> AVM Fritzbox router boards may contain an additional ATH79
> based SoC that has the wifi cards connected.
> This patch adds bindings for this remote processor.
>
> Signed-off-by: Daniel Kestrel <kestrelseventyfour@gmail.com>
> ---
> .../bindings/remoteproc/avm,wasp-rproc.yaml | 61 +++++++++++++++++++
> 1 file changed, 61 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/remoteproc/avm,wasp-rproc.yaml
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/avm,wasp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/avm,wasp-rproc.yaml
> new file mode 100644
> index 000000000000..e8618706a34f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/remoteproc/avm,wasp-rproc.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/remoteproc/avm,wasp-rproc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AVM WASP processor controller bindings
> +
> +maintainers:
> + - Daniel Kestrel <kestrelseventyfour@gmail.com>
> +
> +description: |
> + This document defines the bindings for the remoteproc component that loads and
> + boots firmwares on the AVM Wireless Assistant Support Processor (WASP) SoC
> + that is attached to some AVM Fritzbox devices (3390, 3490, 5490, 5491, 7490).
> +
> +properties:
> + compatible:
> + enum:
> + - avm,fritzbox3390-wasp
> + - avm,fritzbox3490-wasp
> + - avm,fritzbox5490-wasp
> + - avm,fritzbox5491-wasp
> + - avm,fritzbox7490-wasp
> +
> + avm,wasp-mdio:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Lantiq GSWIP switch mdio.

"git grep 'mdio.*=.*<'" gives existing 'mdio-parent-bus', 'mdio-device',
and 'mdio-handle'. 'mdio-parent-bus' is the only one documented, but is
for muxes. I'd go with 'mdio-device' here.

> +
> + avm,wasp-port:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Network port, where the WASP SoC is connected to.

Maybe something already exists here too.

> +
> + avm,reset-gpios:
> + description: Reset gpio of the WASP SoC.
> + maxItems: 1

Just 'reset-gpios' is fine here as that is somewhat standard.

> +
> + avm,startup-gpios:
> + description: Startup gpio of the WASP SoC.

s/gpio/GPIO/

Perhaps some detail on what it does besides just 'startup'.

> + maxItems: 1
> +
> +required:
> + - compatible
> + - avm,wasp-mdio
> + - avm,wasp-port
> + - avm,reset-gpios
> + - avm,startup-gpios
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + remoteproc {
> + compatible = "avm,fritzbox7490-wasp";
> + avm,wasp-mdio = <&gswip_mdio>;
> + avm,wasp-port = <&port5>;
> + avm,reset-gpios = <&gpio 34 GPIO_ACTIVE_HIGH>;
> + avm,startup-gpios = <&gpio 5 GPIO_ACTIVE_HIGH>;
> + };
> --
> 2.17.1
>
>

\
 
 \ /
  Last update: 2022-08-02 17:26    [W:0.056 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site