lkml.org 
[lkml]   [2022]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] tracing: Add .percent suffix option to histogram values
On Tue, 2 Aug 2022 14:49:36 +0800
kernel test robot <lkp@intel.com> wrote:

> All errors (new ones prefixed by >>):
>
> >> ld.lld: error: undefined symbol: __udivdi3

This is due to this:

> @@ -5190,18 +5202,34 @@ static void hist_trigger_print_key(struct seq_file *m,
> seq_puts(m, "}");
> }
>
> +/* Get the 100 times of the percentage of @val in @total */
> +static inline unsigned int __get_percentage(u64 val, u64 total)
> +{
> + if (val < (U64_MAX / 10000))
> + return (unsigned int)(val * 10000 / total);
> + else
> + return val / (total / 10000);
> +}
> +

You can't use '/' on u64 values. You have to use div64*(). Otherwise 32 bit
architectures may use floating point operations or glibc helpers.

See the other divisions in trace_events_hist.c that do so too.

-- Steve


> >>> referenced by trace_events_hist.c:5211 (kernel/trace/trace_events_hist.c:5211)
> >>> trace/trace_events_hist.o:(hist_show) in archive kernel/built-in.a
> >>> referenced by trace_events_hist.c:0 (kernel/trace/trace_events_hist.c:0)
> >>> trace/trace_events_hist.o:(hist_show) in archive kernel/built-in.a
> >>> referenced by trace_events_hist.c:5211 (kernel/trace/trace_events_hist.c:5211)
> >>> trace/trace_events_hist.o:(hist_show) in archive kernel/built-in.a
> >>> referenced 1 more times

\
 
 \ /
  Last update: 2022-08-02 16:57    [W:0.064 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site