Messages in this thread | | | From | Miguel Ojeda <> | Date | Tue, 2 Aug 2022 16:53:17 +0200 | Subject | Re: [PATCH v8 17/31] rust: add `kernel` crate |
| |
On Tue, Aug 2, 2022 at 4:36 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > I did? Maybe I didn't realize we would end up with 15k lines of code > from different parts of the kernel like amba bus and filesystem apis all > in a single commit. If so, my fault, but as other parts of this > discussion show, it is going to be required to get the subsystem > maintainers to be able to review the interfaces to their code in order > to get any further.
No worries at all! Probably a misunderstanding on my side too.
I am more than happy to spit it into quite a few patches, and it will also help with the C-d-b's.
As for reviewing -- since we keep adding abstractions and new features to show how things may work, we would be chasing new reviews all the time. Would it be better to drop some of those for the moment and get the "core" in first?
That way we can merge each subsystem part by part later, send it to the proper MLs as smaller patches, get maintainers on board, etc. etc., and it would be more manageable for everyone.
Cheers, Miguel
| |