[lkml]   [2022]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v8 17/31] rust: add `kernel` crate
On Tue, Aug 02, 2022 at 04:33:17PM +0200, Miguel Ojeda wrote:
> Hi Greg,
> On Tue, Aug 2, 2022 at 3:34 PM Greg Kroah-Hartman
> <> wrote:
> >
> > This is huge for a single commit, and pretty much impossible to review
> > as-is.
> >
> > Any chance you can turn this into a series of commits, that starts with
> > the basics and builds on top of that? Right now you are mixing many
> > many different subsystems all at once into one commit, guaranteeing that
> > no one can review the whole thing properly :(
> Yeah, of course, I am happy to do that -- I did it for the `sync`
> module, but stopped splitting further since I understood you wanted it
> this way from what you told me on February.

I did? Maybe I didn't realize we would end up with 15k lines of code
from different parts of the kernel like amba bus and filesystem apis all
in a single commit. If so, my fault, but as other parts of this
discussion show, it is going to be required to get the subsystem
maintainers to be able to review the interfaces to their code in order
to get any further.


greg k-h

 \ /
  Last update: 2022-08-02 16:37    [W:0.057 / U:1.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site