lkml.org 
[lkml]   [2022]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH bpf-next v2 2/3] bpf: export crash_kexec() as destructive kfunc
On Tue, Aug 02, 2022 at 12:46:42PM +0200, Jiri Olsa wrote:
> On Tue, Aug 02, 2022 at 11:10:29AM +0200, Artem Savkov wrote:
> > +static int __init crash_kfunc_init(void)
> > +{
> > + register_btf_kfunc_id_set(BPF_PROG_TYPE_TRACING, &kexec_kfunc_set);
> > + return 0;
>
> should we do 'return register_btf_kfunc_id_set(...' in here?

Maybe, but as far as I can tell the return value for init calls does
absolutely nothing except for showing up in a debug message. So I don't
think it will be worth a respin, but if there is one anyway I'll change
this.

--
Artem

\
 
 \ /
  Last update: 2022-08-02 16:02    [W:0.450 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site