lkml.org 
[lkml]   [2022]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] spi: dt-binding: add Microchip CoreQSPI compatible
On Tue, Aug 02, 2022 at 10:52:25AM +0200, Krzysztof Kozlowski wrote:
> On 01/08/2022 11:42, Naga Sureshkumar Relli wrote:

> > - enum:
> > - - microchip,mpfs-spi
> > - - microchip,mpfs-qspi
> > + oneOf:
> > + - description: Microchip's Polarfire SoC SPI controller.
> > + const: microchip,mpfs-spi
> > + - description: Microchip's Polarfire SoC QSPI controller.

> Useless descriptions - they repeat compatible. Just keep it as enum and
> skip descriptions. What value do they bring?

Someone not familiar with the full Microchip product line might not be
aware of the expansion of mpfs, it's not blindingly obvious.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-08-02 15:14    [W:0.258 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site