Messages in this thread | | | Date | Tue, 2 Aug 2022 14:36:33 +0300 | From | Vladimir Oltean <> | Subject | Re: [PATCH net-next v1 07/10] net: dsa: microchip: warn about not supported synclko properties on KSZ9893 chips |
| |
On Fri, Jul 29, 2022 at 03:03:43PM +0200, Oleksij Rempel wrote: > KSZ9893 family of chips do not support synclko property. So warn about > without preventing driver from start. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > drivers/net/dsa/microchip/ksz_common.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c > index 71b5349d006a..d3a9836c706f 100644 > --- a/drivers/net/dsa/microchip/ksz_common.c > +++ b/drivers/net/dsa/microchip/ksz_common.c > @@ -1916,6 +1916,13 @@ int ksz_switch_register(struct ksz_device *dev) > dev_err(dev->dev, "inconsistent synclko settings\n"); > return -EINVAL; > } > + > + if (dev->chip_id == KSZ9893_CHIP_ID && (dev->synclko_125 || > + dev->synclko_disable)) { > + dev_warn(dev->dev, "microchip,synclko-125 and microchip,synclko-disable " > + "properties are not supported on this chip. " > + "Please fix you devicetree.\n");
s/you/your/
Does KSZ8 have a REFCLK output of any sort? If it doesn't, then "microchip,synclko-disable" is kind of supported, right?
I wonder what there is to gain by saying that you should remove some device tree properties from non-ksz9477. After all, anyone can add any random properties to a KSZ8 switch OF node and you won't warn about those.
> + } > } > > ret = dsa_register_switch(dev->ds); > -- > 2.30.2 >
| |