lkml.org 
[lkml]   [2022]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] dt-bindings: PCI: mediatek-gen3: Add support for MT8188 and MT8195
From
Date
Hi Krzysztof,

Thanks for your comment.

On Tue, 2022-08-02 at 10:59 +0200, Krzysztof Kozlowski wrote:
> On 01/08/2022 13:37, Jianjun Wang wrote:
> > MT8188 and MT8195 are ARM platform SoCs with the same PCIe IP as
> > MT8192.
> >
> > Also add new clock name "peri_mem" since the MT8188 and MT8195 use
> > clock
> > "peri_mem" instead of "top_133m".
> >
> > Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
> > ---
> > Changes in v3:
> > Use enum property to add the new clock name.
> >
> > Changes in v2:
> > Merge two patches into one.
> > ---
> > .../bindings/pci/mediatek-pcie-gen3.yaml | 14
> > ++++++++++++--
> > 1 file changed, 12 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml
> > index 0499b94627ae..a0ca9c7f5dfa 100644
> > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > @@ -48,7 +48,14 @@ allOf:
> >
> > properties:
> > compatible:
> > - const: mediatek,mt8192-pcie
> > + oneOf:
> > + - items:
> > + - enum:
> > + - mediatek,mt8188-pcie
> > + - mediatek,mt8195-pcie
> > + - const: mediatek,mt8192-pcie
> > + - items:
>
> You have one item, so this is just const. Or enum if you expect it
> to
> grow soon.

It makes sense, I'll remove this "items" and just keep the const item
in the next version.

Thanks.
>
> > + - const: mediatek,mt8192-pcie
> >
> > reg:
> > maxItems: 1
> > @@ -84,7 +91,9 @@ properties:
> > - const: tl_96m
> > - const: tl_32k
> > - const: peri_26m
> > - - const: top_133m
> > + - enum:
> > + - top_133m # for MT8192
> > + - peri_mem # for MT8188/MT8195
>
> This requires allOf:if:then restricting it further per variant.
>
>
>
> Best regards,
> Krzysztof

\
 
 \ /
  Last update: 2022-08-02 11:44    [W:0.065 / U:0.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site