lkml.org 
[lkml]   [2022]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] dt-bindings: PCI: host-generic-pci: Allow IOMMU and MSI properties
From
On 2022-07-28 18:51, Rob Herring wrote:
> Allow 'iommu-map', 'iommu-map-mask', and 'msi-parent' properties for
> generic host. This fixes unevaluated property warnings on Arm Juno, AMD
> Seattle, and FSL LS1028a.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/pci/host-generic-pci.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/host-generic-pci.yaml b/Documentation/devicetree/bindings/pci/host-generic-pci.yaml
> index 6bcaa8f2c3cf..d25423aa7167 100644
> --- a/Documentation/devicetree/bindings/pci/host-generic-pci.yaml
> +++ b/Documentation/devicetree/bindings/pci/host-generic-pci.yaml
> @@ -106,6 +106,9 @@ properties:
> maxItems: 3
>
> dma-coherent: true
> + iommu-map: true
> + iommu-map-mask: true
> + msi-parent: true

Hmm, in general this set looks suspiciously incomplete without msi-map
and msi-map-mask too. Am I right in thinking that the ideal thing to do
here would be to convert pci-msi.txt and pci-iommu.txt to schema and
$ref them?

Robin.

>
> required:
> - compatible

\
 
 \ /
  Last update: 2022-08-02 11:26    [W:0.113 / U:2.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site