lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 136/545] arm64: dts: mt7622: fix BPI-R64 WPS button
    Date
    From: Nick Hainke <vincent@systemli.org>

    [ Upstream commit c98e6e683632386a3bd284acda4342e68aec4c41 ]

    The bananapi R64 (BPI-R64) experiences wrong WPS button signals.
    In OpenWrt pushing the WPS button while powering on the device will set
    it to recovery mode. Currently, this also happens without any user
    interaction. In particular, the wrong signals appear while booting the
    device or restarting it, e.g. after doing a system upgrade. If the
    device is in recovery mode the user needs to manually power cycle or
    restart it.

    The official BPI-R64 sources set the WPS button to GPIO_ACTIVE_LOW in
    the device tree. This setting seems to suppress the unwanted WPS button
    press signals. So this commit changes the button from GPIO_ACTIVE_HIGH to
    GPIO_ACTIVE_LOW.

    The official BPI-R64 sources can be found on
    https://github.com/BPI-SINOVOIP/BPI-R64-openwrt

    Fixes: 0b6286dd96c0 ("arm64: dts: mt7622: add bananapi BPI-R64 board")

    Suggested-by: INAGAKI Hiroshi <musashino.open@gmail.com>
    Signed-off-by: Nick Hainke <vincent@systemli.org>
    Link: https://lore.kernel.org/r/20220630111746.4098-1-vincent@systemli.org
    Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
    index 9a11e5c60c26..3053f484c8cc 100644
    --- a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
    +++ b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
    @@ -49,7 +49,7 @@ factory {
    wps {
    label = "wps";
    linux,code = <KEY_WPS_BUTTON>;
    - gpios = <&pio 102 GPIO_ACTIVE_HIGH>;
    + gpios = <&pio 102 GPIO_ACTIVE_LOW>;
    };
    };

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:03    [W:6.769 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site