lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 129/545] cpufreq: zynq: Fix refcount leak in zynq_get_revision
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit d1ff2559cef0f6f8d97fba6337b28adb10689e16 ]

    of_find_compatible_node() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when done.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: 00f7dc636366 ("ARM: zynq: Add support for SOC_BUS")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220605082807.21526-1-linmq006@gmail.com
    Signed-off-by: Michal Simek <michal.simek@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm/mach-zynq/common.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c
    index e1ca6a5732d2..15e8a321a713 100644
    --- a/arch/arm/mach-zynq/common.c
    +++ b/arch/arm/mach-zynq/common.c
    @@ -77,6 +77,7 @@ static int __init zynq_get_revision(void)
    }

    zynq_devcfg_base = of_iomap(np, 0);
    + of_node_put(np);
    if (!zynq_devcfg_base) {
    pr_err("%s: Unable to map I/O memory\n", __func__);
    return -1;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:00    [W:2.145 / U:1.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site