lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 109/545] meson-mx-socinfo: Fix refcount leak in meson_mx_socinfo_init
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit a2106f38077e78afcb4bf98fdda3e162118cfb3d ]

    of_find_matching_node() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when not need anymore.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: 5e68c0fc8df8 ("soc: amlogic: Add Meson6/Meson8/Meson8b/Meson8m2 SoC Information driver")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
    Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
    Link: https://lore.kernel.org/r/20220524065729.33689-1-linmq006@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/soc/amlogic/meson-mx-socinfo.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/soc/amlogic/meson-mx-socinfo.c b/drivers/soc/amlogic/meson-mx-socinfo.c
    index 78f0f1aeca57..92125dd65f33 100644
    --- a/drivers/soc/amlogic/meson-mx-socinfo.c
    +++ b/drivers/soc/amlogic/meson-mx-socinfo.c
    @@ -126,6 +126,7 @@ static int __init meson_mx_socinfo_init(void)
    np = of_find_matching_node(NULL, meson_mx_socinfo_analog_top_ids);
    if (np) {
    analog_top_regmap = syscon_node_to_regmap(np);
    + of_node_put(np);
    if (IS_ERR(analog_top_regmap))
    return PTR_ERR(analog_top_regmap);

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 17:59    [W:4.089 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site