lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 102/545] firmware: tegra: Fix error check return value of debugfs_create_file()
    Date
    From: Lv Ruyi <lv.ruyi@zte.com.cn>

    [ Upstream commit afcdb8e55c91c6ff0700ab272fd0f74e899ab884 ]

    If an error occurs, debugfs_create_file() will return ERR_PTR(-ERROR),
    so use IS_ERR() to check it.

    Reported-by: Zeal Robot <zealci@zte.com.cn>
    Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
    Signed-off-by: Thierry Reding <treding@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/firmware/tegra/bpmp-debugfs.c | 10 +++++-----
    1 file changed, 5 insertions(+), 5 deletions(-)

    diff --git a/drivers/firmware/tegra/bpmp-debugfs.c b/drivers/firmware/tegra/bpmp-debugfs.c
    index 440d99c63638..fad97ec8e81f 100644
    --- a/drivers/firmware/tegra/bpmp-debugfs.c
    +++ b/drivers/firmware/tegra/bpmp-debugfs.c
    @@ -429,7 +429,7 @@ static int bpmp_populate_debugfs_inband(struct tegra_bpmp *bpmp,
    mode |= attrs & DEBUGFS_S_IWUSR ? 0200 : 0;
    dentry = debugfs_create_file(name, mode, parent, bpmp,
    &bpmp_debug_fops);
    - if (!dentry) {
    + if (IS_ERR(dentry)) {
    err = -ENOMEM;
    goto out;
    }
    @@ -680,7 +680,7 @@ static int bpmp_populate_dir(struct tegra_bpmp *bpmp, struct seqbuf *seqbuf,

    if (t & DEBUGFS_S_ISDIR) {
    dentry = debugfs_create_dir(name, parent);
    - if (!dentry)
    + if (IS_ERR(dentry))
    return -ENOMEM;
    err = bpmp_populate_dir(bpmp, seqbuf, dentry, depth+1);
    if (err < 0)
    @@ -693,7 +693,7 @@ static int bpmp_populate_dir(struct tegra_bpmp *bpmp, struct seqbuf *seqbuf,
    dentry = debugfs_create_file(name, mode,
    parent, bpmp,
    &debugfs_fops);
    - if (!dentry)
    + if (IS_ERR(dentry))
    return -ENOMEM;
    }
    }
    @@ -743,11 +743,11 @@ int tegra_bpmp_init_debugfs(struct tegra_bpmp *bpmp)
    return 0;

    root = debugfs_create_dir("bpmp", NULL);
    - if (!root)
    + if (IS_ERR(root))
    return -ENOMEM;

    bpmp->debugfs_mirror = debugfs_create_dir("debug", root);
    - if (!bpmp->debugfs_mirror) {
    + if (IS_ERR(bpmp->debugfs_mirror)) {
    err = -ENOMEM;
    goto out;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 17:59    [W:4.016 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site