lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 021/545] KVM: x86: Tag kvm_mmu_x86_module_init() with __init
    Date
    From: Sean Christopherson <seanjc@google.com>

    commit 982bae43f11c37b51d2f1961bb25ef7cac3746fa upstream.

    Mark kvm_mmu_x86_module_init() with __init, the entire reason it exists
    is to initialize variables when kvm.ko is loaded, i.e. it must never be
    called after module initialization.

    Fixes: 1d0e84806047 ("KVM: x86/mmu: Resolve nx_huge_pages when kvm.ko is loaded")
    Cc: stable@vger.kernel.org
    Reviewed-by: Kai Huang <kai.huang@intel.com>
    Tested-by: Michael Roth <michael.roth@amd.com>
    Signed-off-by: Sean Christopherson <seanjc@google.com>
    Message-Id: <20220803224957.1285926-2-seanjc@google.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/x86/include/asm/kvm_host.h | 2 +-
    arch/x86/kvm/mmu/mmu.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    --- a/arch/x86/include/asm/kvm_host.h
    +++ b/arch/x86/include/asm/kvm_host.h
    @@ -1340,7 +1340,7 @@ static inline int kvm_arch_flush_remote_
    return -ENOTSUPP;
    }

    -void kvm_mmu_x86_module_init(void);
    +void __init kvm_mmu_x86_module_init(void);
    int kvm_mmu_vendor_module_init(void);
    void kvm_mmu_vendor_module_exit(void);

    --- a/arch/x86/kvm/mmu/mmu.c
    +++ b/arch/x86/kvm/mmu/mmu.c
    @@ -5886,7 +5886,7 @@ static int set_nx_huge_pages(const char
    * nx_huge_pages needs to be resolved to true/false when kvm.ko is loaded, as
    * its default value of -1 is technically undefined behavior for a boolean.
    */
    -void kvm_mmu_x86_module_init(void)
    +void __init kvm_mmu_x86_module_init(void)
    {
    if (nx_huge_pages == -1)
    __set_nx_huge_pages(get_nx_auto_mode());

    \
     
     \ /
      Last update: 2022-08-19 17:52    [W:2.724 / U:1.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site