lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5.15 565/779] ASoC: mt6797-mt6351: Fix refcount leak in mt6797_mt6351_dev_probe
    Hi!

    > From: Miaoqian Lin <linmq006@gmail.com>
    >
    > [ Upstream commit 7472eb8d7dd12b6b9b1a4f4527719cc9c7f5965f ]
    >
    > of_parse_phandle() returns a node pointer with refcount
    > incremented, we should use of_node_put() on it when not need anymore.
    > Add missing of_node_put() to avoid refcount leak.

    AFAICT this has serious problems:

    > +++ b/sound/soc/mediatek/mt6797/mt6797-mt6351.c
    > @@ -217,7 +217,8 @@ static int mt6797_mt6351_dev_probe(struct platform_device *pdev)
    > if (!codec_node) {
    > dev_err(&pdev->dev,
    > "Property 'audio-codec' missing or invalid\n");
    > - return -EINVAL;
    > + ret = -EINVAL;
    > + goto put_platform_node;
    > }
    > for_each_card_prelinks(card, i, dai_link) {
    > if (dai_link->codecs->name)
    > @@ -230,6 +231,9 @@ static int mt6797_mt6351_dev_probe(struct platform_device *pdev)
    > dev_err(&pdev->dev, "%s snd_soc_register_card fail %d\n",
    > __func__, ret);
    >
    > + of_node_put(codec_node);
    > +put_platform_node:
    > + of_node_put(platform_node);
    > return ret;
    > }

    platform_node is stashed away in struct, and so is codec_node; we
    should not be freeing those references in success case, right?

    dai_link->platforms->of_node = platform_node;

    Best regards,
    Pavel
    --
    DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
    HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2022-08-19 15:16    [W:4.641 / U:0.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site