lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 2/3] driver: input: matric-keypad: add reduced matrix support
From
On 19/08/2022 09:59, Gireesh.Hiremath@in.bosch.com wrote:
>
> struct gpio_desc **row_gpios;
> struct gpio_desc **col_gpios;
> + struct gpio_desc **desc_gpios;
>
> - unsigned int num_row_gpios;
> - unsigned int num_col_gpios;
> + unsigned int num_row_gpios;
> + unsigned int num_col_gpios;

Do not mix up unrelated changes... One logical change, one commit.
Entire patch should be cleanup from this (it's not only here but in
several places). Except that you have build failures to fix...

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-08-19 14:20    [W:0.118 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site