Messages in this thread | | | Date | Fri, 19 Aug 2022 15:10:29 +0300 | Subject | Re: [PATCH v3 2/3] driver: input: matric-keypad: add reduced matrix support | From | Krzysztof Kozlowski <> |
| |
On 19/08/2022 09:59, Gireesh.Hiremath@in.bosch.com wrote: > > struct gpio_desc **row_gpios; > struct gpio_desc **col_gpios; > + struct gpio_desc **desc_gpios; > > - unsigned int num_row_gpios; > - unsigned int num_col_gpios; > + unsigned int num_row_gpios; > + unsigned int num_col_gpios;
Do not mix up unrelated changes... One logical change, one commit. Entire patch should be cleanup from this (it's not only here but in several places). Except that you have build failures to fix...
Best regards, Krzysztof
| |