Messages in this thread Patch in this message | | | From | Christophe Leroy <> | Subject | Re: [PATCH -next] powerpc/powermac: Fix symbol not declared warnings | Date | Fri, 19 Aug 2022 08:12:14 +0000 |
| |
Le 19/08/2022 à 09:43, Chen Lifu a écrit : > 1. ppc_override_l2cr and ppc_override_l2cr_value are only used in > l2cr_init() function, so move them inside the function. > 2. has_l2cache is not used outside of the file, so mark it static, and > do not initialise statics to 0.
You can do much more simple. Use *l2cr directly and remove ppc_override_l2cr and ppc_override_l2cr_value completely. And move the printk inside the 'if (l2cr)'.
> > Fixes the following warning: > > arch/powerpc/platforms/powermac/setup.c:74:5: warning: symbol 'ppc_override_l2cr' was not declared. Should it be static? > arch/powerpc/platforms/powermac/setup.c:75:5: warning: symbol 'ppc_override_l2cr_value' was not declared. Should it be static? > arch/powerpc/platforms/powermac/setup.c:76:5: warning: symbol 'has_l2cache' was not declared. Should it be static? > > Signed-off-by: Chen Lifu <chenlifu@huawei.com> > --- > arch/powerpc/platforms/powermac/setup.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/powerpc/platforms/powermac/setup.c b/arch/powerpc/platforms/powermac/setup.c > index 04daa7f0a03c..f8b847a2f5b5 100644 > --- a/arch/powerpc/platforms/powermac/setup.c > +++ b/arch/powerpc/platforms/powermac/setup.c > @@ -68,13 +68,11 @@ > > #include "pmac.h" > > #undef SHOW_GATWICK_IRQS > > -int ppc_override_l2cr = 0; > -int ppc_override_l2cr_value; > -int has_l2cache = 0; > +static int has_l2cache; > > int pmac_newworld; > > static int current_root_goodness = -1; > > @@ -226,10 +224,13 @@ static void __init ohare_init(void) > } > } > > static void __init l2cr_init(void) > { > + int ppc_override_l2cr = 0; > + int ppc_override_l2cr_value; > + > /* Checks "l2cr-value" property in the registry */ > if (cpu_has_feature(CPU_FTR_L2CR)) { > struct device_node *np; > > for_each_of_cpu_node(np) { > -- > 2.37.1 >
| |