Messages in this thread | | | Subject | Re: [PATCH 1/9] LoongArch/ftrace: Add basic support | From | Qing Zhang <> | Date | Sat, 20 Aug 2022 09:34:48 +0800 |
| |
On 2022/8/20 上午12:53, Steven Rostedt wrote: > On Fri, 19 Aug 2022 17:29:29 +0800 > Jinyang He <hejinyang@loongson.cn> wrote: > >> It seems this patch adds non-dynamic ftrace, this code should not >> appear here. >> BTW is it really necessary for non-dynamic ftrace? I do not use it >> directly and frequently, IMHO, non-dynamic can be completely >> >> replaced dynamic? > > Note, I keep the non dynamic ftrace around for debugging purposes. > > But sure, it's pretty useless. It's also good for bringing ftrace to a new > architecture (like this patch is doing), as it is easier to implement than > dynamic ftrace, and getting the non-dynamic working is usually the first > step in getting dynamic ftrace working. > > But it's really up to the arch maintainers to keep it or not. > Before submitting, I saw that other architectures almost kept non-dynamic methods without cleaning up, I tend to keep them. How do you think, Huacai. :)
Thanks, - Qing > -- Steve >
| |