lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next] net: sched: remove duplicate check of user rights in qdisc
From


On 2022/8/19 11:44, Jakub Kicinski wrote:
> On Thu, 18 Aug 2022 15:25:00 +0800 Zhengchao Shao wrote:
>> - if ((n->nlmsg_type != RTM_GETACTION) &&
>> - !netlink_capable(skb, CAP_NET_ADMIN))
>> - return -EPERM;
>
> This check is not network namespace capable, right?
>
> We're probably fine making it namespace aware but it needs to be a
> separate change.

Hi Jakub:
Thank you for your reply. I will add the wrong deletion back in V2. And
I will also consider to make checking namespace aware in action function.

Zhengchao Shao

\
 
 \ /
  Last update: 2022-08-19 06:24    [W:0.528 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site