lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] parisc: move from strlcpy with unused retval to strscpy
From
On 8/18/22 23:00, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
>
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

applied to parisc git tree.
Thanks!
Helge

> ---
> drivers/parisc/led.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/parisc/led.c b/drivers/parisc/led.c
> index 1e4a5663d011..d4be9d2ee74d 100644
> --- a/drivers/parisc/led.c
> +++ b/drivers/parisc/led.c
> @@ -646,7 +646,7 @@ int lcd_print( const char *str )
> cancel_delayed_work_sync(&led_task);
>
> /* copy display string to buffer for procfs */
> - strlcpy(lcd_text, str, sizeof(lcd_text));
> + strscpy(lcd_text, str, sizeof(lcd_text));
>
> /* Set LCD Cursor to 1st character */
> gsc_writeb(lcd_info.reset_cmd1, LCD_CMD_REG);

\
 
 \ /
  Last update: 2022-08-19 21:28    [W:0.041 / U:1.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site