Messages in this thread | | | Date | Fri, 19 Aug 2022 20:29:47 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v2 5/7] EDAC/ghes: Prevent chipset-specific edac from loading after ghes_edac is registered |
| |
On Fri, Aug 19, 2022 at 05:48:39PM +0000, Kani, Toshi wrote: > This flag is a static variable, say ghes_present, which is set to > false initially. ghes_probe() sets it to true. ghes_edac_preferred() > (aka. ghes_get_device) checks this flag at beginning and returns false > if this flag is false. It does not get unlatched since ACPI GHES table > is static.
What is that flag needed for at all?
There are two possibilities:
1. ghes_probe() succeeds. ghes_edac loads properly and other drivers use ghes_get_devices() to know when to load.
2. ghes_probe() fails and that is caught during platform testing of all those platforms who wish to use ghes_edac. BIOS is fixed and goto 1.
No need for funky flags whatsoever.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |