Messages in this thread | | | Date | Fri, 19 Aug 2022 22:13:16 +0530 | Subject | Re: [PATCH v3 5/5] arm64: dts: qcom: sc7280: Add Reset support for gpu | From | Akhil P Oommen <> |
| |
On 8/19/2022 11:47 AM, Krzysztof Kozlowski wrote: > On 18/08/2022 23:18, Akhil P Oommen wrote: >> Add support for Reset using GPUCC driver for GPU. This helps to ensure >> that GPU state is reset by making sure that CX head switch is collapsed. >> >> Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com> >> --- >> >> (no changes since v1) >> >> arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> index e66fc67..f5257d6 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> @@ -2243,6 +2243,9 @@ >> nvmem-cells = <&gpu_speed_bin>; >> nvmem-cell-names = "speed_bin"; >> >> + resets = <&gpucc GPU_CX_COLLAPSE>; >> + reset-names = "cx_collapse"; >> + > I think this is not allowed by bindings. Did you test your change with > dtbs_check? > > Best regards, > Krzysztof My bad! Thanks for pointing this out. Fixed in v4 with patch 5/6.
-Akhil.
| |