lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 442/545] scsi: qla2xxx: Fix erroneous mailbox timeout after PCI error injection
    Date
    From: Quinn Tran <qutran@marvell.com>

    commit f260694e6463b63ae550aad25ddefe94cb1904da upstream.

    Clear wait for mailbox interrupt flag to prevent stale mailbox:

    Feb 22 05:22:56 ltcden4-lp7 kernel: qla2xxx [0135:90:00.1]-500a:4: LOOP UP detected (16 Gbps).
    Feb 22 05:22:59 ltcden4-lp7 kernel: qla2xxx [0135:90:00.1]-d04c:4: MBX Command timeout for cmd 69, ...

    To fix the issue, driver needs to clear the MBX_INTR_WAIT flag on purging
    the mailbox. When the stale mailbox completion does arrive, it will be
    dropped.

    Link: https://lore.kernel.org/r/20220616053508.27186-11-njavali@marvell.com
    Fixes: b6faaaf796d7 ("scsi: qla2xxx: Serialize mailbox request")
    Cc: Naresh Bannoth <nbannoth@in.ibm.com>
    Cc: Kyle Mahlkuch <Kyle.Mahlkuch@ibm.com>
    Cc: stable@vger.kernel.org
    Reported-by: Naresh Bannoth <nbannoth@in.ibm.com>
    Tested-by: Naresh Bannoth <nbannoth@in.ibm.com>
    Signed-off-by: Quinn Tran <qutran@marvell.com>
    Signed-off-by: Nilesh Javali <njavali@marvell.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/scsi/qla2xxx/qla_mbx.c | 12 ++++++------
    1 file changed, 6 insertions(+), 6 deletions(-)

    --- a/drivers/scsi/qla2xxx/qla_mbx.c
    +++ b/drivers/scsi/qla2xxx/qla_mbx.c
    @@ -271,6 +271,12 @@ qla2x00_mailbox_command(scsi_qla_host_t
    atomic_inc(&ha->num_pend_mbx_stage3);
    if (!wait_for_completion_timeout(&ha->mbx_intr_comp,
    mcp->tov * HZ)) {
    + ql_dbg(ql_dbg_mbx, vha, 0x117a,
    + "cmd=%x Timeout.\n", command);
    + spin_lock_irqsave(&ha->hardware_lock, flags);
    + clear_bit(MBX_INTR_WAIT, &ha->mbx_cmd_flags);
    + spin_unlock_irqrestore(&ha->hardware_lock, flags);
    +
    if (chip_reset != ha->chip_reset) {
    spin_lock_irqsave(&ha->hardware_lock, flags);
    ha->flags.mbox_busy = 0;
    @@ -281,12 +287,6 @@ qla2x00_mailbox_command(scsi_qla_host_t
    rval = QLA_ABORTED;
    goto premature_exit;
    }
    - ql_dbg(ql_dbg_mbx, vha, 0x117a,
    - "cmd=%x Timeout.\n", command);
    - spin_lock_irqsave(&ha->hardware_lock, flags);
    - clear_bit(MBX_INTR_WAIT, &ha->mbx_cmd_flags);
    - spin_unlock_irqrestore(&ha->hardware_lock, flags);
    -
    } else if (ha->flags.purge_mbox ||
    chip_reset != ha->chip_reset) {
    spin_lock_irqsave(&ha->hardware_lock, flags);

    \
     
     \ /
      Last update: 2022-08-19 18:48    [W:2.190 / U:0.420 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site