lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 488/545] dm writecache: set a default MAX_WRITEBACK_JOBS
    Date
    From: Mikulas Patocka <mpatocka@redhat.com>

    [ Upstream commit ca7dc242e358e46d963b32f9d9dd829785a9e957 ]

    dm-writecache has the capability to limit the number of writeback jobs
    in progress. However, this feature was off by default. As such there
    were some out-of-memory crashes observed when lowering the low
    watermark while the cache is full.

    This commit enables writeback limit by default. It is set to 256MiB or
    1/16 of total system memory, whichever is smaller.

    Cc: stable@vger.kernel.org
    Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
    Signed-off-by: Mike Snitzer <snitzer@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/md/dm-writecache.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c
    index 9d6ae3e64285..13cc318db012 100644
    --- a/drivers/md/dm-writecache.c
    +++ b/drivers/md/dm-writecache.c
    @@ -20,7 +20,7 @@

    #define HIGH_WATERMARK 50
    #define LOW_WATERMARK 45
    -#define MAX_WRITEBACK_JOBS 0
    +#define MAX_WRITEBACK_JOBS min(0x10000000 / PAGE_SIZE, totalram_pages() / 16)
    #define ENDIO_LATENCY 16
    #define WRITEBACK_LATENCY 64
    #define AUTOCOMMIT_BLOCKS_SSD 65536
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:48    [W:4.050 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site