lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 411/545] ASoC: audio-graph-card: Add of_node_put() in fail path
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit 65fb8e2ef3531a6e950060fca6e551c923fb0f0e ]

    In asoc_simple_parse_dai(), we should call of_node_put() for the
    reference returned by of_graph_get_port_parent() in fail path.

    Fixes: ae30a694da4c ("ASoC: simple-card-utils: add asoc_simple_card_parse_dai()")
    Signed-off-by: Liang He <windhl@126.com>
    Link: https://lore.kernel.org/r/20220721144308.1301587-1-windhl@126.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/generic/audio-graph-card.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c
    index 0c640308ed80..bfbee2d716f3 100644
    --- a/sound/soc/generic/audio-graph-card.c
    +++ b/sound/soc/generic/audio-graph-card.c
    @@ -149,8 +149,10 @@ static int asoc_simple_parse_dai(struct device_node *ep,
    * if he unbinded CPU or Codec.
    */
    ret = snd_soc_get_dai_name(&args, &dlc->dai_name);
    - if (ret < 0)
    + if (ret < 0) {
    + of_node_put(node);
    return ret;
    + }

    dlc->of_node = node;

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:44    [W:8.097 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site