lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 414/545] video: fbdev: sis: fix typos in SiS_GetModeID()
    Date
    From: Rustam Subkhankulov <subkhankulov@ispras.ru>

    [ Upstream commit 3eb8fccc244bfb41a7961969e4db280d44911226 ]

    The second operand of a '&&' operator has no impact on expression
    result for cases 400 and 512 in SiS_GetModeID().

    Judging by the logic and the names of the variables, in both cases a
    typo was made.

    Found by Linux Verification Center (linuxtesting.org) with SVACE.

    Signed-off-by: Rustam Subkhankulov <subkhankulov@ispras.ru>
    Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
    Signed-off-by: Helge Deller <deller@gmx.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/video/fbdev/sis/init.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/video/fbdev/sis/init.c b/drivers/video/fbdev/sis/init.c
    index fde27feae5d0..d6b2ce95a859 100644
    --- a/drivers/video/fbdev/sis/init.c
    +++ b/drivers/video/fbdev/sis/init.c
    @@ -355,12 +355,12 @@ SiS_GetModeID(int VGAEngine, unsigned int VBFlags, int HDisplay, int VDisplay,
    }
    break;
    case 400:
    - if((!(VBFlags & CRT1_LCDA)) || ((LCDwidth >= 800) && (LCDwidth >= 600))) {
    + if((!(VBFlags & CRT1_LCDA)) || ((LCDwidth >= 800) && (LCDheight >= 600))) {
    if(VDisplay == 300) ModeIndex = ModeIndex_400x300[Depth];
    }
    break;
    case 512:
    - if((!(VBFlags & CRT1_LCDA)) || ((LCDwidth >= 1024) && (LCDwidth >= 768))) {
    + if((!(VBFlags & CRT1_LCDA)) || ((LCDwidth >= 1024) && (LCDheight >= 768))) {
    if(VDisplay == 384) ModeIndex = ModeIndex_512x384[Depth];
    }
    break;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:43    [W:2.343 / U:0.764 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site