lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 422/545] powerpc/xive: Fix refcount leak in xive_get_max_prio
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 255b650cbec6849443ce2e0cdd187fd5e61c218c ]

    of_find_node_by_path() returns a node pointer with
    refcount incremented, we should use of_node_put() on it when done.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: eac1e731b59e ("powerpc/xive: guest exploitation of the XIVE interrupt controller")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20220605053225.56125-1-linmq006@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/powerpc/sysdev/xive/spapr.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/arch/powerpc/sysdev/xive/spapr.c b/arch/powerpc/sysdev/xive/spapr.c
    index b57eeaff7bb3..38e8b9896174 100644
    --- a/arch/powerpc/sysdev/xive/spapr.c
    +++ b/arch/powerpc/sysdev/xive/spapr.c
    @@ -710,6 +710,7 @@ static bool xive_get_max_prio(u8 *max_prio)
    }

    reg = of_get_property(rootdn, "ibm,plat-res-int-priorities", &len);
    + of_node_put(rootdn);
    if (!reg) {
    pr_err("Failed to read 'ibm,plat-res-int-priorities' property\n");
    return false;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:38    [W:2.242 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site