lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 404/545] iommu/arm-smmu: qcom_iommu: Add of_node_put() when breaking out of loop
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit a91eb6803c1c715738682fece095145cbd68fe0b ]

    In qcom_iommu_has_secure_context(), we should call of_node_put()
    for the reference 'child' when breaking out of for_each_child_of_node()
    which will automatically increase and decrease the refcount.

    Fixes: d051f28c8807 ("iommu/qcom: Initialize secure page table")
    Signed-off-by: Liang He <windhl@126.com>
    Link: https://lore.kernel.org/r/20220719124955.1242171-1-windhl@126.com
    Signed-off-by: Will Deacon <will@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/iommu/arm/arm-smmu/qcom_iommu.c | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    diff --git a/drivers/iommu/arm/arm-smmu/qcom_iommu.c b/drivers/iommu/arm/arm-smmu/qcom_iommu.c
    index b30d6c966e2c..a24390c548a9 100644
    --- a/drivers/iommu/arm/arm-smmu/qcom_iommu.c
    +++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c
    @@ -766,9 +766,12 @@ static bool qcom_iommu_has_secure_context(struct qcom_iommu_dev *qcom_iommu)
    {
    struct device_node *child;

    - for_each_child_of_node(qcom_iommu->dev->of_node, child)
    - if (of_device_is_compatible(child, "qcom,msm-iommu-v1-sec"))
    + for_each_child_of_node(qcom_iommu->dev->of_node, child) {
    + if (of_device_is_compatible(child, "qcom,msm-iommu-v1-sec")) {
    + of_node_put(child);
    return true;
    + }
    + }

    return false;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:37    [W:4.142 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site