lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 347/545] USB: serial: fix tty-port initialized comments
    Date
    From: Johan Hovold <johan@kernel.org>

    [ Upstream commit 688ee1d1785c1359f9040f615dd8e6054962bce2 ]

    Fix up the tty-port initialized comments which got truncated and
    obfuscated when replacing the old ASYNCB_INITIALIZED flag.

    Fixes: d41861ca19c9 ("tty: Replace ASYNC_INITIALIZED bit and update atomically")
    Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/serial/sierra.c | 3 ++-
    drivers/usb/serial/usb-serial.c | 2 +-
    drivers/usb/serial/usb_wwan.c | 3 ++-
    3 files changed, 5 insertions(+), 3 deletions(-)

    diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
    index 57fc3c31712e..018a27d879b8 100644
    --- a/drivers/usb/serial/sierra.c
    +++ b/drivers/usb/serial/sierra.c
    @@ -737,7 +737,8 @@ static void sierra_close(struct usb_serial_port *port)

    /*
    * Need to take susp_lock to make sure port is not already being
    - * resumed, but no need to hold it due to initialized
    + * resumed, but no need to hold it due to the tty-port initialized
    + * flag.
    */
    spin_lock_irq(&intfdata->susp_lock);
    if (--intfdata->open_ports == 0)
    diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
    index 27e3bb58c872..e8dd4603b201 100644
    --- a/drivers/usb/serial/usb-serial.c
    +++ b/drivers/usb/serial/usb-serial.c
    @@ -254,7 +254,7 @@ static int serial_open(struct tty_struct *tty, struct file *filp)
    *
    * Shut down a USB serial port. Serialized against activate by the
    * tport mutex and kept to matching open/close pairs
    - * of calls by the initialized flag.
    + * of calls by the tty-port initialized flag.
    *
    * Not called if tty is console.
    */
    diff --git a/drivers/usb/serial/usb_wwan.c b/drivers/usb/serial/usb_wwan.c
    index b2285d5a869d..628a75d1232a 100644
    --- a/drivers/usb/serial/usb_wwan.c
    +++ b/drivers/usb/serial/usb_wwan.c
    @@ -435,7 +435,8 @@ void usb_wwan_close(struct usb_serial_port *port)

    /*
    * Need to take susp_lock to make sure port is not already being
    - * resumed, but no need to hold it due to initialized
    + * resumed, but no need to hold it due to the tty-port initialized
    + * flag.
    */
    spin_lock_irq(&intfdata->susp_lock);
    if (--intfdata->open_ports == 0)
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:33    [W:5.091 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site