lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 368/545] ASoC: codecs: da7210: add check for i2c_add_driver
    Date
    From: Jiasheng Jiang <jiasheng@iscas.ac.cn>

    [ Upstream commit 82fa8f581a954ddeec1602bed9f8b4a09d100e6e ]

    As i2c_add_driver could return error if fails, it should be
    better to check the return value.
    However, if the CONFIG_I2C and CONFIG_SPI_MASTER are both true,
    the return value of i2c_add_driver will be covered by
    spi_register_driver.
    Therefore, it is necessary to add check and return error if fails.

    Fixes: aa0e25caafb7 ("ASoC: da7210: Add support for spi regmap")
    Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
    Link: https://lore.kernel.org/r/20220531094712.2376759-1-jiasheng@iscas.ac.cn
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/codecs/da7210.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/sound/soc/codecs/da7210.c b/sound/soc/codecs/da7210.c
    index 3d05c37f676e..4544ed8741b6 100644
    --- a/sound/soc/codecs/da7210.c
    +++ b/sound/soc/codecs/da7210.c
    @@ -1336,6 +1336,8 @@ static int __init da7210_modinit(void)
    int ret = 0;
    #if IS_ENABLED(CONFIG_I2C)
    ret = i2c_add_driver(&da7210_i2c_driver);
    + if (ret)
    + return ret;
    #endif
    #if defined(CONFIG_SPI_MASTER)
    ret = spi_register_driver(&da7210_spi_driver);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:33    [W:2.934 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site