lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 355/545] RDMA/mlx5: Add missing check for return value in get namespace flow
    Date
    From: Maor Gottlieb <maorg@nvidia.com>

    [ Upstream commit c9776457bd5eaad4ce4ecb17af8d8f3cc6957c0b ]

    Add missing check for return value when calling to
    mlx5_ib_ft_type_to_namespace, even though it can't really fail in this
    specific call.

    Fixes: 52438be44112 ("RDMA/mlx5: Allow inserting a steering rule to the FDB")
    Link: https://lore.kernel.org/r/7b9ceda217d9368a51dc47a46b769bad4af9ac92.1659256069.git.leonro@nvidia.com
    Reviewed-by: Itay Aveksis <itayav@nvidia.com>
    Signed-off-by: Maor Gottlieb <maorg@nvidia.com>
    Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
    Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/hw/mlx5/fs.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/infiniband/hw/mlx5/fs.c b/drivers/infiniband/hw/mlx5/fs.c
    index b3391ecedda7..0404e6f22d37 100644
    --- a/drivers/infiniband/hw/mlx5/fs.c
    +++ b/drivers/infiniband/hw/mlx5/fs.c
    @@ -2081,12 +2081,10 @@ static int mlx5_ib_matcher_ns(struct uverbs_attr_bundle *attrs,
    if (err)
    return err;

    - if (flags) {
    - mlx5_ib_ft_type_to_namespace(
    + if (flags)
    + return mlx5_ib_ft_type_to_namespace(
    MLX5_IB_UAPI_FLOW_TABLE_TYPE_NIC_TX,
    &obj->ns_type);
    - return 0;
    - }
    }

    obj->ns_type = MLX5_FLOW_NAMESPACE_BYPASS;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:30    [W:2.216 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site