lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 313/545] mmc: sdhci-of-esdhc: Fix refcount leak in esdhc_signal_voltage_switch
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit b5899a3e2f783a27b268e38d37f9b24c71bddf45 ]

    of_find_matching_node() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when not need anymore.
    Add missing of_node_put() to avoid refcount leak.
    of_node_put() checks null pointer.

    Fixes: ea35645a3c66 ("mmc: sdhci-of-esdhc: add support for signal voltage switch")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220523144255.10310-1-linmq006@gmail.com
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mmc/host/sdhci-of-esdhc.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
    index 343648fcbc31..d53374991e13 100644
    --- a/drivers/mmc/host/sdhci-of-esdhc.c
    +++ b/drivers/mmc/host/sdhci-of-esdhc.c
    @@ -904,6 +904,7 @@ static int esdhc_signal_voltage_switch(struct mmc_host *mmc,
    scfg_node = of_find_matching_node(NULL, scfg_device_ids);
    if (scfg_node)
    scfg_base = of_iomap(scfg_node, 0);
    + of_node_put(scfg_node);
    if (scfg_base) {
    sdhciovselcr = SDHCIOVSELCR_TGLEN |
    SDHCIOVSELCR_VSELVAL;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:28    [W:4.303 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site