lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 332/545] RDMA/rtrs: Define MIN_CHUNK_SIZE
    Date
    From: Gioh Kim <gi-oh.kim@cloud.ionos.com>

    [ Upstream commit 3f3d0eabc14b6ea1fcbe85a60ee9d44e2b930b8a ]

    Define MIN_CHUNK_SIZE to replace the hard-coding number.
    We need 4k for metadata, so MIN_CHUNK_SIZE should be at least 8k.

    Link: https://lore.kernel.org/r/20210528113018.52290-7-jinpu.wang@ionos.com
    Signed-off-by: Gioh Kim <gi-oh.kim@ionos.com>
    Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
    Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/ulp/rtrs/rtrs-pri.h | 1 +
    drivers/infiniband/ulp/rtrs/rtrs-srv.c | 4 ++--
    2 files changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/infiniband/ulp/rtrs/rtrs-pri.h b/drivers/infiniband/ulp/rtrs/rtrs-pri.h
    index 51c60f542876..333de9d52172 100644
    --- a/drivers/infiniband/ulp/rtrs/rtrs-pri.h
    +++ b/drivers/infiniband/ulp/rtrs/rtrs-pri.h
    @@ -56,6 +56,7 @@ enum {
    * somewhere between 1 and 65536 and it depends on the system.
    */
    MAX_SESS_QUEUE_DEPTH = 65536,
    + MIN_CHUNK_SIZE = 8192,

    RTRS_HB_INTERVAL_MS = 5000,
    RTRS_HB_MISSED_MAX = 5,
    diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv.c b/drivers/infiniband/ulp/rtrs/rtrs-srv.c
    index b033bfa9f383..b152a742cd3c 100644
    --- a/drivers/infiniband/ulp/rtrs/rtrs-srv.c
    +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.c
    @@ -2193,9 +2193,9 @@ static int check_module_params(void)
    sess_queue_depth, 1, MAX_SESS_QUEUE_DEPTH);
    return -EINVAL;
    }
    - if (max_chunk_size < 4096 || !is_power_of_2(max_chunk_size)) {
    + if (max_chunk_size < MIN_CHUNK_SIZE || !is_power_of_2(max_chunk_size)) {
    pr_err("Invalid max_chunk_size value %d, has to be >= %d and should be power of two.\n",
    - max_chunk_size, 4096);
    + max_chunk_size, MIN_CHUNK_SIZE);
    return -EINVAL;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:27    [W:4.070 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site