Messages in this thread | | | Date | Fri, 19 Aug 2022 09:52:50 +0300 | Subject | Re: [PATCH 1/2] dt-bindings: lan966x-otpc: document Lan966X OTPC | From | Krzysztof Kozlowski <> |
| |
On 18/08/2022 19:44, Horatiu Vultur wrote: > Document Lan966x OTP controller. > > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com> > --- > .../nvmem/microchip,lan966x-otpc.yaml | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/nvmem/microchip,lan966x-otpc.yaml > > diff --git a/Documentation/devicetree/bindings/nvmem/microchip,lan966x-otpc.yaml b/Documentation/devicetree/bindings/nvmem/microchip,lan966x-otpc.yaml > new file mode 100644 > index 000000000000..b19465971930 > --- /dev/null > +++ b/Documentation/devicetree/bindings/nvmem/microchip,lan966x-otpc.yaml > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/nvmem/microchip,lan966x-otpc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip LAN966X OTP Controller (OTPC) > + > +maintainers: > + - Horatiu Vultur <horatiu.vultur@microchip.com> > + > +description: | > + OTP controller drives a NVMEM memory where system specific data > + (e.g. hardware configuration settings, chip identifiers) or > + user specific data could be stored. > + > +allOf: > + - $ref: "nvmem.yaml#"
No need for quotes.
> + > +properties: > + compatible: > + items: > + - const: microchip,lan966x-otpc
No wildcards in compatible (which will also affect the file name as it should match the compatible).
> + - const: syscon
Is OTP controller also system controller register region? This is a bit odd and looks like hack not to use nvmem subsystem.
> + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + otpc: otp@e0021000 { > + compatible = "microchip,lan966x-otpc", "syscon"; > + reg = <0xe0021000 0x300>; > + }; > + > +...
Best regards, Krzysztof
| |