lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 287/545] clk: mediatek: reset: Fix written reset bit offset
    Date
    From: Rex-BC Chen <rex-bc.chen@mediatek.com>

    [ Upstream commit edabcf71d100fd433a0fc2d0c97057c446c33b2a ]

    Original assert/deassert bit is BIT(0), but it's more resonable to modify
    them to BIT(id % 32) which is based on id.

    This patch will not influence any previous driver because the reset is
    only used for thermal. The id (MT8183_INFRACFG_AO_THERM_SW_RST) is 0.

    Fixes: 64ebb57a3df6 ("clk: reset: Modify reset-controller driver")
    Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
    Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
    Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
    Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
    Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
    Link: https://lore.kernel.org/r/20220523093346.28493-3-rex-bc.chen@mediatek.com
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/clk/mediatek/reset.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/clk/mediatek/reset.c b/drivers/clk/mediatek/reset.c
    index cb939c071b0c..89916acf0bc3 100644
    --- a/drivers/clk/mediatek/reset.c
    +++ b/drivers/clk/mediatek/reset.c
    @@ -25,7 +25,7 @@ static int mtk_reset_assert_set_clr(struct reset_controller_dev *rcdev,
    struct mtk_reset *data = container_of(rcdev, struct mtk_reset, rcdev);
    unsigned int reg = data->regofs + ((id / 32) << 4);

    - return regmap_write(data->regmap, reg, 1);
    + return regmap_write(data->regmap, reg, BIT(id % 32));
    }

    static int mtk_reset_deassert_set_clr(struct reset_controller_dev *rcdev,
    @@ -34,7 +34,7 @@ static int mtk_reset_deassert_set_clr(struct reset_controller_dev *rcdev,
    struct mtk_reset *data = container_of(rcdev, struct mtk_reset, rcdev);
    unsigned int reg = data->regofs + ((id / 32) << 4) + 0x4;

    - return regmap_write(data->regmap, reg, 1);
    + return regmap_write(data->regmap, reg, BIT(id % 32));
    }

    static int mtk_reset_assert(struct reset_controller_dev *rcdev,
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:22    [W:4.048 / U:1.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site