lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 272/545] mtd: rawnand: meson: Fix a potential double free issue
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit ec0da06337751b18f6dee06b6526e0f0d6e80369 ]

    When meson_nfc_nand_chip_cleanup() is called, it will call:
    meson_nfc_free_buffer(&meson_chip->nand);
    nand_cleanup(&meson_chip->nand);

    nand_cleanup() in turn will call nand_detach() which calls the
    .detach_chip() which is here meson_nand_detach_chip().

    meson_nand_detach_chip() already calls meson_nfc_free_buffer(), so we
    could double free some memory.

    Fix it by removing the unneeded explicit call to meson_nfc_free_buffer().

    Fixes: 8fae856c5350 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Acked-by: Liang Yang <liang.yang@amlogic.com>
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Link: https://lore.kernel.org/linux-mtd/ec15c358b8063f7c50ff4cd628cf0d2e14e43f49.1653064877.git.christophe.jaillet@wanadoo.fr
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mtd/nand/raw/meson_nand.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
    index 817bddccb775..327a2257ec26 100644
    --- a/drivers/mtd/nand/raw/meson_nand.c
    +++ b/drivers/mtd/nand/raw/meson_nand.c
    @@ -1307,7 +1307,6 @@ static int meson_nfc_nand_chip_cleanup(struct meson_nfc *nfc)
    if (ret)
    return ret;

    - meson_nfc_free_buffer(&meson_chip->nand);
    nand_cleanup(&meson_chip->nand);
    list_del(&meson_chip->node);
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:22    [W:4.216 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site