lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 238/545] can: hi311x: do not report txerr and rxerr during bus-off
    Date
    From: Vincent Mailhol <mailhol.vincent@wanadoo.fr>

    [ Upstream commit a22bd630cfff496b270211745536e50e98eb3a45 ]

    During bus off, the error count is greater than 255 and can not fit in
    a u8.

    Fixes: 57e83fb9b746 ("can: hi311x: Add Holt HI-311x CAN driver")
    Link: https://lore.kernel.org/all/20220719143550.3681-6-mailhol.vincent@wanadoo.fr
    Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/can/spi/hi311x.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/can/spi/hi311x.c b/drivers/net/can/spi/hi311x.c
    index 7d2315c8cacb..28273e84171a 100644
    --- a/drivers/net/can/spi/hi311x.c
    +++ b/drivers/net/can/spi/hi311x.c
    @@ -670,8 +670,6 @@ static irqreturn_t hi3110_can_ist(int irq, void *dev_id)

    txerr = hi3110_read(spi, HI3110_READ_TEC);
    rxerr = hi3110_read(spi, HI3110_READ_REC);
    - cf->data[6] = txerr;
    - cf->data[7] = rxerr;
    tx_state = txerr >= rxerr ? new_state : 0;
    rx_state = txerr <= rxerr ? new_state : 0;
    can_change_state(net, cf, tx_state, rx_state);
    @@ -684,6 +682,9 @@ static irqreturn_t hi3110_can_ist(int irq, void *dev_id)
    hi3110_hw_sleep(spi);
    break;
    }
    + } else {
    + cf->data[6] = txerr;
    + cf->data[7] = rxerr;
    }
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:19    [W:4.210 / U:1.588 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site