lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 223/545] mediatek: mt76: mac80211: Fix missing of_node_put() in mt76_led_init()
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit 0a14c1d0113f121151edf34333cdf212dd209190 ]

    We should use of_node_put() for the reference 'np' returned by
    of_get_child_by_name() which will increase the refcount.

    Fixes: 17f1de56df05 ("mt76: add common code shared between multiple chipsets")
    Signed-off-by: Liang He <windhl@126.com>
    Signed-off-by: Felix Fietkau <nbd@nbd.name>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/mediatek/mt76/mac80211.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/wireless/mediatek/mt76/mac80211.c b/drivers/net/wireless/mediatek/mt76/mac80211.c
    index 466447a5184f..81ff3b4c6c1b 100644
    --- a/drivers/net/wireless/mediatek/mt76/mac80211.c
    +++ b/drivers/net/wireless/mediatek/mt76/mac80211.c
    @@ -107,6 +107,7 @@ static int mt76_led_init(struct mt76_dev *dev)
    if (!of_property_read_u32(np, "led-sources", &led_pin))
    dev->led_pin = led_pin;
    dev->led_al = of_property_read_bool(np, "led-active-low");
    + of_node_put(np);
    }

    return led_classdev_register(dev->dev, &dev->led_cdev);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:12    [W:5.088 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site