lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 155/545] pwm: sifive: Shut down hardware only after pwmchip_remove() completed
    Date
    From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

    [ Upstream commit 2375e964d541bb09158cd2dff67b5d74e8de61cd ]

    The PWMs are expected to be functional until pwmchip_remove() is called.
    So disable the clks only afterwards.

    Fixes: 9e37a53eb051 ("pwm: sifive: Add a driver for SiFive SoC PWM")
    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Tested-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
    Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pwm/pwm-sifive.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c
    index 1def1bc59240..9cc0612f0849 100644
    --- a/drivers/pwm/pwm-sifive.c
    +++ b/drivers/pwm/pwm-sifive.c
    @@ -326,6 +326,9 @@ static int pwm_sifive_remove(struct platform_device *dev)
    struct pwm_device *pwm;
    int ch;

    + pwmchip_remove(&ddata->chip);
    + clk_notifier_unregister(ddata->clk, &ddata->notifier);
    +
    for (ch = 0; ch < ddata->chip.npwm; ch++) {
    pwm = &ddata->chip.pwms[ch];
    if (pwm->state.enabled)
    @@ -333,8 +336,6 @@ static int pwm_sifive_remove(struct platform_device *dev)
    }

    clk_unprepare(ddata->clk);
    - pwmchip_remove(&ddata->chip);
    - clk_notifier_unregister(ddata->clk, &ddata->notifier);

    return 0;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:12    [W:3.452 / U:1.704 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site