lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 210/545] drm/mediatek: dpi: Only enable dpi after the bridge is enabled
    Date
    From: Guillaume Ranquet <granquet@baylibre.com>

    [ Upstream commit aed61ef6beb911cc043af0f2f291167663995065 ]

    Enabling the dpi too early causes glitches on screen.

    Move the call to mtk_dpi_enable() at the end of the bridge_enable
    callback to ensure everything is setup properly before enabling dpi.

    Fixes: 9e629c17aa8d ("drm/mediatek: Add DPI sub driver")
    Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
    Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
    Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
    Link: https://patchwork.kernel.org/project/linux-mediatek/patch/20220701035845.16458-16-rex-bc.chen@mediatek.com/
    Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/mediatek/mtk_dpi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
    index 554ad60af4e9..c1ae336df683 100644
    --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
    +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
    @@ -397,7 +397,6 @@ static int mtk_dpi_power_on(struct mtk_dpi *dpi)
    if (dpi->pinctrl && dpi->pins_dpi)
    pinctrl_select_state(dpi->pinctrl, dpi->pins_dpi);

    - mtk_dpi_enable(dpi);
    return 0;

    err_pixel:
    @@ -534,6 +533,7 @@ static void mtk_dpi_bridge_enable(struct drm_bridge *bridge)

    mtk_dpi_power_on(dpi);
    mtk_dpi_set_display_mode(dpi, &dpi->mode);
    + mtk_dpi_enable(dpi);
    }

    static const struct drm_bridge_funcs mtk_dpi_bridge_funcs = {
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:12    [W:2.567 / U:0.476 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site