lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 185/545] drm/mcde: Fix refcount leak in mcde_dsi_bind
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 3a149169e4a2f9127022fec6ef5d71b4e804b3b9 ]

    Every iteration of for_each_available_child_of_node() decrements
    the reference counter of the previous node. There is no decrement
    when break out from the loop and results in refcount leak.
    Add missing of_node_put() to fix this.

    Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Link: https://patchwork.freedesktop.org/patch/msgid/20220525115411.65455-1-linmq006@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/mcde/mcde_dsi.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcde_dsi.c
    index 5275b2723293..64e6fb806290 100644
    --- a/drivers/gpu/drm/mcde/mcde_dsi.c
    +++ b/drivers/gpu/drm/mcde/mcde_dsi.c
    @@ -1118,6 +1118,7 @@ static int mcde_dsi_bind(struct device *dev, struct device *master,
    bridge = of_drm_find_bridge(child);
    if (!bridge) {
    dev_err(dev, "failed to find bridge\n");
    + of_node_put(child);
    return -EINVAL;
    }
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:12    [W:4.487 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site