lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 192/545] drm/vc4: dsi: Correct pixel order for DSI0
    Date
    From: Dave Stevenson <dave.stevenson@raspberrypi.com>

    [ Upstream commit edfe84ae0df16be1251b5a8e840d95f1f3827500 ]

    For slightly unknown reasons, dsi0 takes a different pixel format
    to dsi1, and that has to be set in the pixel valve.

    Amend the setup accordingly.

    Fixes: a86773d120d7 ("drm/vc4: Add support for feeding DSI encoders from the pixel valve.")
    Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
    Link: https://lore.kernel.org/r/20220613144800.326124-14-maxime@cerno.tech
    Signed-off-by: Maxime Ripard <maxime@cerno.tech>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/vc4/vc4_crtc.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c
    index f4ccca922e44..f4e64db07d4e 100644
    --- a/drivers/gpu/drm/vc4/vc4_crtc.c
    +++ b/drivers/gpu/drm/vc4/vc4_crtc.c
    @@ -319,7 +319,8 @@ static void vc4_crtc_config_pv(struct drm_crtc *crtc)
    u32 pixel_rep = (mode->flags & DRM_MODE_FLAG_DBLCLK) ? 2 : 1;
    bool is_dsi = (vc4_encoder->type == VC4_ENCODER_TYPE_DSI0 ||
    vc4_encoder->type == VC4_ENCODER_TYPE_DSI1);
    - u32 format = is_dsi ? PV_CONTROL_FORMAT_DSIV_24 : PV_CONTROL_FORMAT_24;
    + bool is_dsi1 = vc4_encoder->type == VC4_ENCODER_TYPE_DSI1;
    + u32 format = is_dsi1 ? PV_CONTROL_FORMAT_DSIV_24 : PV_CONTROL_FORMAT_24;
    u8 ppc = pv_data->pixels_per_clock;
    bool debug_dump_regs = false;

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:09    [W:4.136 / U:0.892 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site