lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 177/545] crypto: sun8i-ss - fix infinite loop in sun8i_ss_setup_ivs()
    Date
    From: Alexey Khoroshilov <khoroshilov@ispras.ru>

    [ Upstream commit d61a7b3decf7f0cf4121a7204303deefd2c7151b ]

    There is no i decrement in while (i >= 0) loop.

    Found by Linux Verification Center (linuxtesting.org) with SVACE.

    Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
    Fixes: 359e893e8af4 ("crypto: sun8i-ss - rework handling of IV")
    Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>
    Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c
    index 7b3be3dc2210..d0954993e2e3 100644
    --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c
    +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c
    @@ -151,6 +151,7 @@ static int sun8i_ss_setup_ivs(struct skcipher_request *areq)
    while (i >= 0) {
    dma_unmap_single(ss->dev, rctx->p_iv[i], ivsize, DMA_TO_DEVICE);
    memzero_explicit(sf->iv[i], ivsize);
    + i--;
    }
    return err;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-19 18:07    [W:4.092 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site