Messages in this thread | | | Date | Fri, 19 Aug 2022 03:00:32 +0800 | From | kernel test robot <> | Subject | Re: [PATCH 12/31] net/tcp: Add tcp_parse_auth_options() |
| |
Hi Dmitry,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on e34cfee65ec891a319ce79797dda18083af33a76]
url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/net-tcp-Add-TCP-AO-support/20220819-010628 base: e34cfee65ec891a319ce79797dda18083af33a76 config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220819/202208190256.Kj0PqjuN-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/c206ead11e78dec4ec0058427d494521f9d53c3f git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Dmitry-Safonov/net-tcp-Add-TCP-AO-support/20220819-010628 git checkout c206ead11e78dec4ec0058427d494521f9d53c3f # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> net/ipv4/tcp_ipv4.c:665:7: warning: "CONFIG_TCP_MD5SIG" is not defined, evaluates to 0 [-Wundef] 665 | #elif CONFIG_TCP_MD5SIG | ^~~~~~~~~~~~~~~~~
vim +/CONFIG_TCP_MD5SIG +665 net/ipv4/tcp_ipv4.c
649 650 /* 651 * This routine will send an RST to the other tcp. 652 * 653 * Someone asks: why I NEVER use socket parameters (TOS, TTL etc.) 654 * for reset. 655 * Answer: if a packet caused RST, it is not for a socket 656 * existing in our system, if it is matched to a socket, 657 * it is just duplicate segment or bug in other side's TCP. 658 * So that we build reply only basing on parameters 659 * arrived with segment. 660 * Exception: precedence violation. We do not implement it in any case. 661 */ 662 663 #ifdef CONFIG_TCP_AO 664 #define OPTION_BYTES MAX_TCP_OPTION_SPACE > 665 #elif CONFIG_TCP_MD5SIG 666 #define OPTION_BYTES TCPOLEN_MD5SIG_ALIGNED 667 #else 668 #define OPTION_BYTES sizeof(__be32) 669 #endif 670
-- 0-DAY CI Kernel Test Service https://01.org/lkp
| |