Messages in this thread | | | Date | Thu, 18 Aug 2022 15:50:02 +0100 | From | Matthew Wilcox <> | Subject | Re: [syzbot] WARNING in iomap_iter |
| |
On Thu, Aug 18, 2022 at 04:41:17PM +0530, Siddh Raman Pant wrote: > include/uapi/linux/loop.h | 12 ++++++------
I don't think changing these from u64 to s64 is the right way to go.
> 2 files changed, 9 insertions(+), 6 deletions(-) > > diff --git a/drivers/block/loop.c b/drivers/block/loop.c > index e3c0ba93c1a3..4ca20ce3158d 100644 > --- a/drivers/block/loop.c > +++ b/drivers/block/loop.c > @@ -977,6 +977,9 @@ loop_set_status_from_info(struct loop_device *lo, > return -EINVAL; > } > > + if (info->lo_offset < 0 || info->lo_sizelimit < 0) > + return -EINVAL; > + > lo->lo_offset = info->lo_offset; > lo->lo_sizelimit = info->lo_sizelimit;
I'd instead do it here:
if (lo>lo_offset < 0 || lo->lo_sizelimit < 0) return -EINVAL;
| |