lkml.org 
[lkml]   [2022]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 0/4] ARM: Convert to ARCH_STACKWALK
From
Date


On 2022/7/27 12:00, Li Huafei wrote:
> This series mainly updates the ARM stack trace code to use the newer and
> simpler arch_stack_walk() interface (see patches 3 and 4). Two issues
> were fixed before that (see patches 1 and 2).
>
> v3:
> - According to the discussion with Linus and Russell in v1:
> - Add a comment about "regs[1]" in patch 2, and remove the
> unnecessary ternary operator in the initialization of
> "frame->ex_frame".
> - Remove the patch "ARM: stacktrace: Allow stack trace saving for
> non-current tasks", and keep the check for not being able to
> unwind non-current tasks (including tasks running on other CPUs)
> when CONFIG_SMP=y in patch 4.
> - Rebase to linux-5.19-rc8.
>
> v2: https://lore.kernel.org/lkml/20220713110020.85511-1-lihuafei1@huawei.com/
> - As suggested by Mark, the commit logs for patch 4 and 5 were
> refined for easy review.
>
> v1: https://lore.kernel.org/lkml/20220712021527.109921-1-lihuafei1@huawei.com/
>
> Li Huafei (4):
> ARM: stacktrace: Skip frame pointer boundary check for
> call_with_stack()
> ARM: stacktrace: Avoid duplicate saving of exception PC value
> ARM: stacktrace: Make stack walk callback consistent with generic code
> ARM: stacktrace: Convert stacktrace to generic ARCH_STACKWALK
>
> arch/arm/Kconfig | 1 +
> arch/arm/include/asm/stacktrace.h | 8 +-
> arch/arm/kernel/perf_callchain.c | 9 +-
> arch/arm/kernel/return_address.c | 9 +-
> arch/arm/kernel/stacktrace.c | 191 ++++++++++++++----------------
> arch/arm/lib/call_with_stack.S | 2 +
> 6 files changed, 110 insertions(+), 110 deletions(-)
>


Hi Russell,

Do you have any more comments on this patch set? Can you add this patch
set to your patch tracker? Thanks!

Thanks,
Huafei

\
 
 \ /
  Last update: 2022-08-18 11:16    [W:0.096 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site