lkml.org 
[lkml]   [2022]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V2 2/2] mm/damon/lru_sort: Remove struct of damon_lru_sort_ram_walk_arg
From

在 2022/8/19 上午1:23, SeongJae Park 写道:
> Hi Xin,
>
> On Thu, 18 Aug 2022 18:57:32 +0800 Xin Hao <xhao@linux.alibaba.com> wrote:
>
>> The struct of 'damon_lru_sort_ram_walk_arg' is the same with struct of
>> 'damon_addr_range', so, there no need to redefine it, just use struct of
>> 'damon_addr_range' instead.
> Reducing code is always good, thanks. However, I think the type of the 'start'
> and 'end' fields of 'struct damon_addr_range' might be changed in a future.
OK,  get it.
> It's very unlikely, though. Also, we might add some more fields to the struct
> in a future. After all, the purpose of 'struct damon_addr_range' is not saving
> the 'start' and 'end' fields of 'struct resource'. I'd like to avoid making
> any possible dependency here, sorry.
>
>
> Thanks,
> SJ
>
> [...]

\
 
 \ /
  Last update: 2022-08-19 03:57    [W:0.055 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site