Messages in this thread | | | Date | Thu, 18 Aug 2022 20:52:37 -0500 | From | Paul Lemmermann <> | Subject | Re: [PATCH] drivers: char: mem: changed 'unsigned' to 'unsigned int' |
| |
On Thu, Aug 18, 2022 at 04:52:11PM +0200, Greg KH wrote: > On Tue, Aug 16, 2022 at 08:35:31PM -0500, Paul Lemmermann wrote: > > found with checkpatch.pl > > That is a very sparse changelog text. > > Why make this change? Please be descriptive. > I wanted to make this change to be more fitting with the kernel coding guidelines, and to reduce a WARNING made with checkpatch preferring the use of 'unsigned int' over 'unsigned'. With NOMMU_MAP_COPY defined in 'include/linux/fs.h' as an unsigned integer, I felt like the change was fitting. I was quickly reminded that the changelog was not properly done, and I now understand that, and will learn from my mistake in the future. As I am a new kernel contributor, and looking to hone my skills, what are my next steps?
Should I:
o Drop the patch and resubmit it, o Simply drop the patch, o Could I change it somehow?, o Or something else?
Thank you very much for your time and effort, - Paul
P.S. Resending this as reply all, as I quickly relized I forgot to do after I send the email to Greg.
| |